Gpu quota #4
Merged
Gpu quota #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/dsmlp/ext/kube.py
Outdated
| @@ -16,9 +18,38 @@ def get_namespace(self, name: str) -> Namespace: | |||
| api = self.get_policy_api() | |||
| v1namespace: V1Namespace = api.read_namespace(name=name) | |||
| metadata: V1ObjectMeta = v1namespace.metadata | |||
|
|
|||
| gpu_quota = 1 | |||
| if metadata.annotations is not None and GPU_LIMIT_ANNOTATION in metadata.annotations: | |||
There was a problem hiding this comment.
what happens if metadata is none (we're not 100% sure of the API)? I'd add that case in and write a test
There was a problem hiding this comment.
Test case added. Just need to resolve low priority gpu bug before PR can be made.
There was a problem hiding this comment.
Low priority bug fixed
|
GPU Validation merged into DSMLP Validator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved GPU Quota validation to DSMLP Validator
Separated GPU validation from AWSEd UID/PID validation using components architecture